Skip to content

refactor: unexport and clean up MarshalFrame#60

Merged
mccutchen merged 3 commits intomainfrom
marshalto-two
Sep 21, 2025
Merged

refactor: unexport and clean up MarshalFrame#60
mccutchen merged 3 commits intomainfrom
marshalto-two

Conversation

@mccutchen
Copy link
Owner

@mccutchen mccutchen commented Sep 21, 2025

Here we drop MarshalFrame from the package's public API and pull in a few small improvements to its implementation from #59.

@github-actions
Copy link

github-actions bot commented Sep 21, 2025 •
edited
Loading

🔥 Run benchmarks comparing f0d5c34 against main:

gh workflow run bench.yaml -f pr_number=60

Note: this comment will update with each new commit.

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

benchstats: 7aee74c...7324442

View full benchmark output on the workflow summary.

goos: linux
goarch: amd64
pkg: github.com/mccutchen/websocket
cpu: AMD EPYC 7763 64-Core Processor                
                  │ ./baseline/bench-results.txt │      ./head/bench-results.txt       │
                  │            sec/op            │   sec/op     vs base                │
ReadFrame/1KiB-4                    572.8n ±  1%   577.2n ± 4%   +0.78% (p=0.022 n=10)
ReadFrame/1MiB-4                    346.1µ ± 10%   289.3µ ± 3%  -16.42% (p=0.000 n=10)
WriteFrame/1KiB-4                   674.5n ±  0%   657.7n ± 2%   -2.49% (p=0.000 n=10)
WriteFrame/1MiB-4                   367.8µ ± 12%   309.9µ ± 2%  -15.76% (p=0.000 n=10)
geomean                             14.89µ         13.58µ        -8.80%

                  │ ./baseline/bench-results.txt │       ./head/bench-results.txt       │
                  │             B/s              │     B/s       vs base                │
ReadFrame/1KiB-4                   1.680Gi ±  1%   1.667Gi ± 4%   -0.77% (p=0.023 n=10)
ReadFrame/1MiB-4                   2.822Gi ± 10%   3.376Gi ± 4%  +19.61% (p=0.000 n=10)
WriteFrame/1KiB-4                  1.426Gi ±  0%   1.463Gi ± 2%   +2.56% (p=0.000 n=10)
WriteFrame/1MiB-4                  2.658Gi ± 13%   3.152Gi ± 2%  +18.59% (p=0.000 n=10)
geomean                            2.059Gi         2.257Gi        +9.61%

                  │ ./baseline/bench-results.txt │       ./head/bench-results.txt        │
                  │             B/op             │     B/op      vs base                 │
ReadFrame/1KiB-4                    1.164Ki ± 0%   1.164Ki ± 0%       ~ (p=1.000 n=10) ¹
ReadFrame/1MiB-4                    1.008Mi ± 0%   1.008Mi ± 0%       ~ (p=0.266 n=10)
WriteFrame/1KiB-4                   1.125Ki ± 0%   1.125Ki ± 0%       ~ (p=1.000 n=10) ¹
WriteFrame/1MiB-4                   1.008Mi ± 0%   1.008Mi ± 0%       ~ (p=0.697 n=10)
geomean                             34.37Ki        34.37Ki       -0.00%
¹ all samples are equal

                  │ ./baseline/bench-results.txt │      ./head/bench-results.txt       │
                  │          allocs/op           │ allocs/op   vs base                 │
ReadFrame/1KiB-4                      5.000 ± 0%   5.000 ± 0%       ~ (p=1.000 n=10) ¹
ReadFrame/1MiB-4                      5.000 ± 0%   5.000 ± 0%       ~ (p=1.000 n=10) ¹
WriteFrame/1KiB-4                     1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
WriteFrame/1MiB-4                     1.000 ± 0%   1.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                               2.236        2.236       +0.00%
¹ all samples are equal

@codecov
Copy link

codecov bot commented Sep 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (7aee74c) to head (f0d5c34).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   92.94%   92.87%   -0.08%     
==========================================
  Files           2        2              
  Lines         496      491       -5     
==========================================
- Hits          461      456       -5     
  Misses         28       28              
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mccutchen mccutchen enabled auto-merge (squash) September 21, 2025 05:06
@mccutchen mccutchen merged commit e5e264c into main Sep 21, 2025
11 of 14 checks passed
@mccutchen mccutchen deleted the marshalto-two branch September 21, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mccutchen